Skip to content

Goal template api impl / Goal SDK / AmoutOf-GoalTemplate - #50

Merged
westei merged 16 commits into
developfrom
umm/326-goal-template-api-impl
May 20, 2026
Merged

Goal template api impl / Goal SDK / AmoutOf-GoalTemplate#50
westei merged 16 commits into
developfrom
umm/326-goal-template-api-impl

Conversation

@westei

@westei westei commented May 13, 2026

Copy link
Copy Markdown
Member

326: Implementation of the Goal APIs for the StudyManager

  • Webservice impl + Test
  • GoalService implementation
  • Extension of the ComponentFactory Webservice for GoalTemplates
  • Some changes and additions to the API - already synced to the Frontend!

325: first simple version of the GaolSDK

  • Simple SDK with all the base function like storing named key/value pairs
  • Extended all the Factory, Properties und Component classes for gaols

346: GoalTemplate for amountOf goal templates (trink, eat and reduce)

Additionally:

  • refactored all ComponentFactory beans to use applicationContext! No Bean that registers directly the Map<String,ComponentFactory> anymore!

Rupert Westenthaler added 3 commits May 11, 2026 14:37
* Webservice impl + Test
* GoalService implementation
* Extension of the ComponentFactory Webservice for GoalTemplates
* Some changes and additions to the API - already synced to the Frontend!

MORE-Platform#325: first simple version of the GaolSDK

* Simple SDK with all the base function like storing named key/value pairs
* Extended all the Factory, Properties und Component classes for gaols

MORE-Platform#346: GoalTemplate for `amountOf` goal templates (trink, eat and reduce)

Additionally:

* refactored all ComponentFactory beans to use applicationContext! No Bean that registers directly the `Map<String,ComponentFactory>` anymore!
@westei
westei requested review from iaigner and janoliver20 May 13, 2026 09:34
@westei westei self-assigned this May 13, 2026
@westei westei changed the title Umm/326 goal template api impl Goal template api impl / Goal SDK / AmoutOf-GoalTemplate May 13, 2026
@github-actions

github-actions Bot commented May 13, 2026

Copy link
Copy Markdown

Test Results

211 tests  +14   210 ✅ +14   1m 40s ⏱️ -6s
 59 suites + 2     1 💤 ± 0 
 59 files   + 2     0 ❌ ± 0 

Results for commit c0115ca. ± Comparison against base commit a137587.

♻️ This comment has been updated with latest results.

@janoliver20 janoliver20 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failen noch

Rupert Westenthaler added 3 commits May 13, 2026 15:06
…ontext.getBean() does never return NULL but throws exceptions instead. This needed to be reflected in the mocks of unit tests!
…ed the dependency in the MoreSDK from the GoalRepository to the GoalService.

@janoliver20 janoliver20 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rupert Westenthaler and others added 10 commits May 19, 2026 08:56
…wed to contain template references. It also validates that all template references are valid in case a allowList is defined. This also defines this allowList for all three usages of this class
…mbh/more-studymanager-backend into umm/326-goal-template-api-impl
…lue. Also added UnitTests for the AmoutOf goal template factory and the ComponentController validate method
@westei
westei merged commit 161d252 into develop May 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants