confluent: fix data race on shutSig in schema registry encoder#4298
Open
confluent: fix data race on shutSig in schema registry encoder#4298
Conversation
The background goroutine started by newSchemaRegistryEncoder re-reads s.shutSig on every loop iteration. When newSchemaRegistryEncoderFromConfig replaces s.shutSig with a new signaller, there is a concurrent read/write race. Capture shutSig in a local variable before launching the goroutine so it never re-reads the struct field. Fixes CON-412
|
Commits Review LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits
Jira