Conversation
onMessage blocks on rawMessageEvents channel send with no shutdown check. During shutdown, readMessages stops consuming the channel, causing the canal handler goroutine to deadlock. canal.Close() then waits for handler goroutines indefinitely. Add a select on shutSig.SoftStopChan() so onMessage unblocks during shutdown, matching the pattern already used in readSnapshot. Fixes CON-432
…tine The goroutine running streamOut.Run(t.Context()) in TestIntegrationMySQLSnapshotAndCDC asserted require.NoError on the result. When StopWithin returns and the test exits, t.Context() is canceled, causing Run to return context.Canceled. This is expected behavior — the CDC stream shuts down cleanly. Use _ = to discard the error, matching the pattern applied in the PostgreSQL tests. Fixes CON-432
…oroutine Same fix as 48917d85e applied to TestIntegrationMySQLCDCSchemaInvalidationOnDDL. The goroutine running streamOut.Run(t.Context()) asserted require.NoError on the result. When the stream shuts down after DDL-triggered re-sync, Run returns context.Canceled which is expected behavior. Fixes CON-434
When StopWithin cancels the resume stream context, Run returns context.Canceled. Match the pattern used in other CDC integration tests so the goroutine does not fail the test on expected shutdown. Fixes CON-444
…m goroutine When StopWithin cancels the stream context, Run returns context.Canceled. Match the pattern used in other CDC integration tests so the goroutine does not fail the test on expected shutdown. Fixes CON-432
|
Commits Review LGTM |
squiidz
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits
Jira