Open
Conversation
Stop() was closing pgConn concurrently with streamMessages() still using it for ReceiveMessage and SendStandbyStatusUpdate. Wait for the stream goroutine to exit (HasStoppedChan) before closing the connection. Fixes CON-406
streamOut.Run correctly returns context.Canceled when the test context is cancelled at shutdown. Use the same filtered error check pattern already used elsewhere in the file. Fixes CON-422
…goroutine The second stream goroutine in TestIntegrationPostgresNoTxnMarkers asserted no error on streamOut.Run(t.Context()), but Run returns context.Canceled when the test ends and the context is canceled. Use _ = to match the first goroutine. Fixes CON-433
…utine Fixes CON-433
|
Commits Review LGTM |
squiidz
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits
Jira