Skip to content

pulsar: various test fixes#4309

Merged
josephwoodward merged 2 commits intomainfrom
mmt/pulsar-fixes-v2
May 4, 2026
Merged

pulsar: various test fixes#4309
josephwoodward merged 2 commits intomainfrom
mmt/pulsar-fixes-v2

Conversation

@mmatczuk
Copy link
Copy Markdown
Contributor

Commits

  • use native ARM image to fix container startup timeouts
  • disable StreamTestAtLeastOnceDelivery due to upstream data race

Jira

  • CON-387
  • CON-415

Switch from apachepulsar/pulsar-standalone:2.8.3 (amd64-only) to
apachepulsar/pulsar:3.3.4 (multi-arch) so the container runs natively
on ARM instead of under x86 emulation. This eliminates the slow
startup that caused context deadline exceeded errors.

Fixes CON-387
The benthos StreamTestAtLeastOnceDelivery test helper has an unsynchronized
concurrent map read/write at stream_test_definitions.go:571-584. A goroutine
iterates a shared map while another writes to it. Since this is in upstream
benthos code, disabling the test until the race is fixed upstream.

Fixes CON-415
@claude
Copy link
Copy Markdown

claude Bot commented Apr 20, 2026

Commits
LGTM

Review
Small, well-scoped test fix: switches the Pulsar image to a multi-arch variant (with an explicit standalone command) and disables StreamTestAtLeastOnceDelivery with an inline comment explaining the upstream data race.

LGTM

This was referenced Apr 20, 2026
@josephwoodward josephwoodward merged commit 8cc1de2 into main May 4, 2026
7 checks passed
@josephwoodward josephwoodward deleted the mmt/pulsar-fixes-v2 branch May 4, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants