redis: increase pubsub channel buffer to prevent message drops#4310
Open
redis: increase pubsub channel buffer to prevent message drops#4310
Conversation
The go-redis pubsub.Channel() defaults to a buffer of 100 messages. Under concurrent writes (e.g. max_in_flight=10 publishing batches of 100), the buffer overflows and messages are silently dropped since Redis PubSub is fire-and-forget. Increase buffer to 2000. Fixes CON-411
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
||
| select { | ||
| case rMsg, open := <-pubsub.Channel(): | ||
| case rMsg, open := <-pubsub.Channel(redis.WithChannelSize(2000)): |
There was a problem hiding this comment.
The literal 2000 is a magic number. Per the godev "Magic Numbers" rule, "Name all numeric constants. Every literal number in logic must have a clear meaning through a named constant or variable." Consider extracting this to a package-level constant (e.g. const pubsubChannelBufferSize = 2000) so the rationale (buffer for concurrent writes) is tied to a named symbol.
|
Commits Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits
Jira