sql: fix data race in TestIntegrationCosmosDB#4314
Merged
josephwoodward merged 1 commit intomainfrom Apr 30, 2026
Merged
Conversation
Skip TestIntegrationCosmosDB when running with the race detector. The gocosmos driver depends on gjrc v0.2.2 which has a data race in GjrcResponse.Body: it uses broken double-checked locking where the outer nil check reads a shared field without the mutex while a background goroutine (spawned eagerly by gjrc.buildResponse) writes it under the mutex. This is a bug in the third-party library that affects every gocosmos REST call and cannot be worked around. gjrc v0.2.2 is the latest available version as of this commit. Fixes CON-409
This was referenced Apr 20, 2026
|
Commits Review LGTM |
josephwoodward
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits
Jira