Project Swiss Cheese

.claude/agents/integration-fix.md

@@ -0,0 +1,70 @@
+---
+name: integration-fix
+description: Fix integration test failures in a Redpanda Connect worktree
+model: opus
+allowed-tools:
+  - Agent
+  - Bash(git:*)
+  - Bash(go:*)
+  - Bash(golangci-lint:*)
+  - Bash(task:*)
+  - Edit
+  - Glob
+  - Grep
+  - Read
+  - Search
+  - TaskCreate
+  - TaskList
+  - TaskUpdate
+  - Write
+  - mcp__jira__jira_read
+---
+
+# Fix Agent
+
+You are fixing integration test failures in a Redpanda Connect git worktree. You receive a list of classified issues and the full failure logs.
+
+You are running autonomously, when facing ambiguity or tradeoffs:
+- Make a decision and proceed.
+- Document your reasoning in the commit message body or as a comment in the code (only if non-obvious).
+- If multiple valid approaches exist, prefer the safer, more conservative option.
+- Never stop to ask. Either fix it or skip it with a written explanation.
+
+## Issue Resolution
+
+Start by creating a task list (TaskCreate) with one task per issue from the "Issues to Fix" list. Update task status as you progress through each step. This gives visibility into the progress and ensures nothing is missed.
+
+For each issue:
+
+Loop (max 3 iterations — if validation doesn't pass, loop back; after 3 failures skip the issue):
+
+1. **Learn.** Read the triage classification, failure logs, the failing test, and the code under test.
+2. **Fix.** Fix the root cause of the failure. Do not modify files outside the failing package unless the fix genuinely requires it. The fix should be targeted at the root cause:
+  - `test_infra`: fix the test infrastructure (e.g. container setup, test helper code), avoid modifying the production code unless the test is incorrect or can be significantly simplified by a minor change.
+  - `code_bug`: fix the production code bug, avoid modifying the test unless the test is incorrect or can be significantly simplified by a minor change.
+3. **Validate.**
+   - Run `golangci-lint run --new-from-rev=HEAD <package-path>` and fix any lint errors.
+   - Run `go test -v -count=1 -timeout 5m -run <TestName> -tags integration <package-path>` to validate the fix.
+4. **Simplify.** If the patch is bigger than 20 lines (`git diff --stat HEAD`), run the `simplify` skill. After simplification, repeat step 3 to validate that the simplified patch still fixes the issue and passes lint.
+
+Then:
+
+6. Commit with a message following the project commit policy:
+   ```
+   <system>: <imperative message>
+
+   <description of the fix, if necessary>
+
+   Fixes CON-XXX
+   ```
+   - `<system>` is the component area in lowercase (e.g., `kafka`, `aws`, `sql`).
+   - `<imperative message>` starts lowercase, uses imperative mood (e.g., "fix flaky consumer test", not "fixed" or "fixes").
+   - `Fixes CON-XXX` uses the `jira_key` from the triage entry. Omit this line if no `jira_key` is present.
+
+7. Mark task completed, or note why it was skipped. Move to the next issue.
+
+## Rules
+
+- One commit per issue. Do not combine fixes across issues.
+- Never push. Only commit locally.
+-

.claude/agents/integration-triage.md

@@ -0,0 +1,45 @@
+---
+name: integration-triage
+description: Classify integration test failures and track them in Jira
+model: sonnet
+allowed-tools:
+  - Glob
+  - Grep
+  - Read
+  - Search
+  - mcp__jira__jira_read
+  - mcp__jira__jira_schema
+  - mcp__jira__jira_write
+---
+
+# Triage Agent
+
+You are a triage agent for Redpanda Connect integration test failures. Your job is to classify each failure and ensure it is tracked in Jira.
+
+## Tools
+
+### Jira MCP
+
+You have access to Jira MCP tools for querying and creating issues. Use them to check existing subtasks under CON-381 and to create or comment on issues.
+
+- Project key: CON
+- Parent issue: CON-381
+- When creating issues, include: test name, package path, full failure output, and your classification reasoning.
+- When searching for duplicates, match on test name and failure pattern, not exact log output.
+- Issue summary format: `<package>: <brief description of failure>`
+
+## Classification
+
+You receive `go test` failure outputs. For each failure:
+
+1. Read the failure output carefully.
+2. **Read the code.** Before classifying, read the failing test and the production code it exercises. Use the package path and test name from the logs to locate the relevant files. This is essential for accurate classification.
+3. Classify the failure:
+   - `test_infra`: The test infrastructure is broken (container setup, port mapping, wait strategy, test helper code, flaky timing). The production code is not at fault.
+   - `code_bug`: The production code has a bug that causes the test to fail. The test itself is correct.
+4. Write a `description` that explains what went wrong and why. When multiple failures share the same underlying cause (e.g., Docker daemon not running, shared container startup failure), use the same description text so they can be grouped.
+5. For each classified failure, check Jira:
+   - Search subtasks of CON-381 for an existing issue matching this failure.
+   - If a matching issue exists: add a comment with the failure logs and timestamp. Set `jira_key` to the existing issue key and `is_new` to false.
+   - If no matching issue exists: create a new subtask under CON-381 with the full failure logs, test name, package, and a clear description. Set `jira_key` to the new issue key and `is_new` to true.
+   - For failures sharing a root cause, a single Jira issue may cover the group. Reference the same `jira_key` for all entries in the group.

.gitignore

@@ -9,6 +9,7 @@ release_notes.md
 .codemogger
 .idea
 .integration
+.integration-worktree
 .task
 .vscode
 .op

cmd/tools/integration/cache.go

@@ -134,6 +134,9 @@ func checkCache(outFile string) PackageCache {
 
 	lastAction := parseEvents(f, 0, EventCallbacks{
 		OnEvent: func(pe ParsedEvent) {
+			if pc.Package == "" && pe.Package != "" {
+				pc.Package = pe.Package
+			}
 			switch pe.Action {
 			case ActionRun:
 				hasRun = true

cmd/tools/integration/fix.go

@@ -0,0 +1,128 @@
+// Copyright 2026 Redpanda Data, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package main
+
+import (
+	"bytes"
+	"errors"
+	"flag"
+	"fmt"
+	"io"
+	"log"
+	"os"
+	"path/filepath"
+	"strings"
+	"time"
+
+	"github.com/redpanda-data/connect/v4/cmd/tools/integration/llmfix"
+)
+
+func cmdFix(args []string) error {
+	fset := flag.NewFlagSet("fix", flag.ExitOnError)
+	fixTimeout := fset.Duration("fix-timeout", 30*time.Minute, "timeout per fix agent run")
+
+	flags, positional := splitFlagsAndArgs(args)
+	if err := fset.Parse(flags); err != nil {
+		return err
+	}
+	positional = append(positional, fset.Args()...)
+
+	if len(positional) != 1 {
+		return errors.New("usage: integration fix <output-file.txt>")
+	}
+
+	filePath, err := filepath.Abs(positional[0])
+	if err != nil {
+		return fmt.Errorf("resolving path: %w", err)
+	}
+
+	cached := checkCache(filePath)
+	if cached.Package == "" {
+		return fmt.Errorf("no package found in %s", filePath)
+	}
+	if cached.Overall() != ResultFail {
+		log.Printf("no failures in %s", filePath)
+		return nil
+	}
+
+	baseSHA, err := resolveHEAD()
+	if err != nil {
+		return err
+	}
+
+	outputDir := filepath.Dir(filePath)
+	slug := pkgSlug(cached.Package)
+	tag := llmfix.NewTag(slug)
+
+	dir, err := llmfix.CreateWorktree(tag, baseSHA)
+	if err != nil {
+		return fmt.Errorf("creating worktree: %w", err)
+	}
+	defer llmfix.CleanupWorktree(dir, tag)
+
+	logPath := filepath.Join(outputDir, tag+".log")
+	logFile, err := os.Create(logPath)
+	if err != nil {
+		return fmt.Errorf("creating log file: %w", err)
+	}
+	defer logFile.Close()
+
+	logger := log.New(io.MultiWriter(logFile, os.Stdout), "", log.LstdFlags)
+
+	op := llmfix.NewOperator(llmfix.FixRequest{
+		Tag:         tag,
+		PkgPath:     cached.Package,
+		TestOutput:  dumpTestOutput(filePath, cached.Tests),
+		OutputDir:   outputDir,
+		WorktreeDir: dir,
+		Timeout:     *fixTimeout,
+	}, logger)
+
+	if err := op.Run(); err != nil {
+		return err
+	}
+
+	commits, err := llmfix.CherryPickCommits(dir, baseSHA)
+	if err != nil {
+		return fmt.Errorf("cherry-pick: %w", err)
+	}
+	for _, c := range commits {
+		logger.Printf("cherry-picked: %s", c)
+	}
+	return nil
+}
+
+func dumpTestOutput(outFile string, tests []CacheEntry) string {
+	var buf strings.Builder
+	for _, t := range tests {
+		if t.Result != ResultFail {
+			continue
+		}
+		buf.WriteString("---\n")
+		fmt.Fprintf(&buf, "Test: %s\n", t.TestName)
+		fmt.Fprintf(&buf, "Location: %s:%d\n\n", outFile, t.FailLine)
+
+		if t.FailLine > 0 {
+			var output bytes.Buffer
+			if err := showTestOutput(&output, outFile, t.FailLine); err != nil {
+				fmt.Fprintf(&buf, "(failed to extract output: %v)\n", err)
+			} else {
+				buf.WriteString(output.String())
+			}
+		}
+		buf.WriteString("\n")
+	}
+	return buf.String()
+}

cmd/tools/integration/flag.go

@@ -0,0 +1,37 @@
+// Copyright 2026 Redpanda Data, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package main
+
+import (
+	"strings"
+)
+
+// splitFlagsAndArgs separates flag-like tokens (starting with "-") from
+// positional arguments so that Go's flag package, which stops at the first
+// non-flag token, can parse interspersed usage like:
+//
+//	run --fix amqp1 --debug
+//
+// Value-taking flags (e.g. --output-dir /tmp) must use --flag=value syntax.
+func splitFlagsAndArgs(args []string) (flags, positional []string) {
+	for _, a := range args {
+		if strings.HasPrefix(a, "-") {
+			flags = append(flags, a)
+		} else {
+			positional = append(positional, a)
+		}
+	}
+	return flags, positional
+}

cmd/tools/integration/flag_test.go

@@ -0,0 +1,76 @@
+// Copyright 2026 Redpanda Data, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package main
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestSplitFlagsAndArgs(t *testing.T) {
+	tests := []struct {
+		name      string
+		args      []string
+		wantFlags []string
+		wantPosn  []string
+	}{
+		{
+			name:      "flags before positional",
+			args:      []string{"--fix", "--clean", "amqp1"},
+			wantFlags: []string{"--fix", "--clean"},
+			wantPosn:  []string{"amqp1"},
+		},
+		{
+			name:      "interspersed flags and positional",
+			args:      []string{"--fix", "amqp1", "--debug", "--race"},
+			wantFlags: []string{"--fix", "--debug", "--race"},
+			wantPosn:  []string{"amqp1"},
+		},
+		{
+			name:      "value flag with equals",
+			args:      []string{"--output-dir=/tmp/out", "kafka"},
+			wantFlags: []string{"--output-dir=/tmp/out"},
+			wantPosn:  []string{"kafka"},
+		},
+		{
+			name:      "multiple positional args",
+			args:      []string{"--fix", "kafka", "redis", "--debug"},
+			wantFlags: []string{"--fix", "--debug"},
+			wantPosn:  []string{"kafka", "redis"},
+		},
+		{
+			name:     "all positional",
+			args:     []string{"kafka", "redis"},
+			wantPosn: []string{"kafka", "redis"},
+		},
+		{
+			name:      "all flags",
+			args:      []string{"--fix", "--debug", "--race"},
+			wantFlags: []string{"--fix", "--debug", "--race"},
+		},
+		{
+			name: "empty",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			flags, posn := splitFlagsAndArgs(tt.args)
+			assert.Equal(t, tt.wantFlags, flags)
+			assert.Equal(t, tt.wantPosn, posn)
+		})
+	}
+}