Distinguish between the two ways to enable SASL#1562
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis change updates the authentication documentation in Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@modules/manage/partials/authentication.adoc`:
- Around line 548-554: The cross-reference to enable-sasl-authentication is
broken because that anchor isn’t present; fix it by either adding the missing
anchor id "enable-sasl-authentication" immediately above the relevant heading
(so the xref resolves) or update the xref to point to an existing anchor/ID used
in this document (for example the actual heading ID for SASL enablement or the
authentication section); ensure the xref text remains
"enable-sasl-authentication" or change it to the correct existing ID and verify
the xref renders.
2a62d06 to
08de78d
Compare
|
Hi @vuldin, |
08de78d to
04bbe3f
Compare
|
Hi @Feediver1 , I think I've handled all feedback up to this point (with one minor question in a comment above). |
|
@vuldin @Feediver1 the only thing not clear to me here is emphatically saying "the cluster configuration enable_sasl:true". It's all about these 'two methods' but WHERE do I set enable_sasl. That's a cluster config. It says it in the rpk command but in a bunch of other places it doesn't. Specifically, one method is setting a cluster config. The other is editing the redpanda.yaml I think (listener method). Can we be even clearer about that |
Co-authored-by: Joyce Fee <102751339+Feediver1@users.noreply.github.com>
Co-authored-by: Joyce Fee <102751339+Feediver1@users.noreply.github.com>
- Replace ✅/❌ emoji with explicit *Advantages:* / *Limitations:* labels
for accessibility (screen readers announce emoji inconsistently)
- Sentence-case table column headers; drop (s) parenthetical
- 'Provides you the flexibility' → 'Lets you configure' (more direct)
- Present tense in bullets ('will use' → 'use')
- Normalize new [source,bash|yaml|json|text] blocks to [,lang] shorthand
to match the rest of this partial
- [source,log] → [,text] (log is not a valid Rouge highlighter language)
- Rename '== Troubleshooting authentication' →
'== Authentication and authorization troubleshooting' since the new
entry is about Schema Registry authorization
- Add intro sentence under the H2 so it isn't an empty parent section
- Fix double space after leading * and add end punctuation to bullets
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Pushed a follow-up commit (e557ceb) applying the style fixes from my earlier review. Summary of changes — all in the new SASL sections, no existing content touched: Accessibility
Style
Formatting
Structure
I did not touch the Schema Registry troubleshooting entry's location — it stays in this partial. If the team decides later that it belongs in Co-authored-by: Claude Code (Opus 4.7 1M). |
No content change. Empty commit to force Netlify, CodeRabbit, and GitHub Actions to rerun on the current branch tip so the build can be re-verified clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Final-pass reviewTwo items worth resolving before merge. Skipping smaller style nits since the content has already had many review rounds. Critical — Schema Registry 403 section also renders on the Kubernetes pageThis partial is included by both In the final file, the new troubleshooting block sits outside any Result: the K8s docs page will also show the section, with a resolution that ends in Fix options:
Suggestion — be explicit about where each method is configured@mattschumpert raised this in March and I don't think the current wording fully addresses it. The intro list says what the two options are, but not where each one lives — the reader has to infer from the Consider tightening the intro bullets so the location is in the definition: * *`enable_sasl`*: A cluster-configuration property (set with `rpk cluster config set enable_sasl true`). A legacy (not deprecated) approach maintained for backwards compatibility…
* *Per-listener configuration*: Listener settings in each broker's `redpanda.yaml`. A more flexible approach that lets you configure different authentication methods on different listeners.That makes the "cluster config vs. broker config file" distinction land before the reader gets into the per-method sections. |
…ing for the troubleshooting H2 Two follow-ups from @micheleRP's final-pass review: 1. Intro bullets now name where each method is configured upfront (cluster-configuration property vs. listener settings in each broker's redpanda.yaml) so the cluster-config-vs-broker-config-file distinction lands before the reader gets into the per-method sections. Addresses @mattschumpert's March feedback. 2. Wrap the new 'Authentication and authorization troubleshooting' H2 in ifndef::env-kubernetes[] ... endif::[]. The partial is included by both modules/manage/pages/security/authentication.adoc (Linux) and modules/manage/pages/kubernetes/security/authentication/k-authentication.adoc (sets :env-kubernetes: true). The resolution step uses systemctl restart redpanda, which doesn't apply on Kubernetes. A platform-agnostic rewrite (or a K8s-specific variant) can be a follow-up if needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Description
This PR makes it clear there are two ways to enable SASL, explains what they are, when to choose one or the other, and why we even have two ways to begin with (why not just one?), and which is the recommended path for new clusters.
Page previews
https://deploy-preview-1562--redpanda-docs-preview.netlify.app/current/manage/security/authentication/
Checks