forked from DataDog/integrations-extras
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redpanda: Add consumer group lag metrics #7
Open
BenPope
wants to merge
8
commits into
redpanda-data:redpanda-3
Choose a base branch
from
BenPope:redpanda_consumer_group_lag
base: redpanda-3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Redpanda: Add consumer group lag metrics #7
BenPope
wants to merge
8
commits into
redpanda-data:redpanda-3
from
BenPope:redpanda_consumer_group_lag
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb1125f
to
814cafd
Compare
cf13333
to
b000319
Compare
The tests now pass. Signed-off-by: Ben Pope <[email protected]>
As of Redpanda v25.1, some consumer group metrics can be disabled by changing cluster config "enable_consumer_group_metrics". These are still enabled by default, but split them out into their own grouping. Signed-off-by: Ben Pope <[email protected]>
Signed-off-by: Ben Pope <[email protected]>
Signed-off-by: Ben Pope <[email protected]>
Signed-off-by: Ben Pope <[email protected]>
Signed-off-by: Ben Pope <[email protected]>
Signed-off-by: Ben Pope <[email protected]>
Signed-off-by: Ben Pope <[email protected]>
b000319
to
6b6f268
Compare
BenPope
commented
Mar 21, 2025
@@ -15,7 +15,7 @@ services: | |||
- PLAINTEXT://0.0.0.0:9092 | |||
- --advertise-kafka-addr | |||
- PLAINTEXT://redpanda:9092 | |||
image: docker.redpanda.com/redpandadata/redpanda:${REDPANDA_VERSION} | |||
image: docker.redpanda.com/redpandadata/redpanda-unstable:${REDPANDA_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously we need to wait for the release and change this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Native consumer group lag metrics allows users to directly monitor lag in their consumer groups. This calculation is not possible within Datadog.
The new lag metrics are low cardinality, and do not have detail into which partitions are behind. That can be obtained by taking the group label from the metrics and running something like:
If that level of detail is sufficient, it's possible to remove the high cardinality metric
kafka.group_offset
, which is what I've done in the default of v3.0.0.Review checklist
no-changelog
label attachedAdditional Notes
This isn't intended to be merged as-is, it's more inspiration and PoC