Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redpanda: Add consumer group lag metrics #7

Open
wants to merge 8 commits into
base: redpanda-3
Choose a base branch
from

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Mar 18, 2025

What does this PR do?

  1. Small refactor of consumer metrics
  2. Add consumer group lag metrics in 2.1.0
  3. Remove committed offsets in 3.0.0

Motivation

Native consumer group lag metrics allows users to directly monitor lag in their consumer groups. This calculation is not possible within Datadog.

The new lag metrics are low cardinality, and do not have detail into which partitions are behind. That can be obtained by taking the group label from the metrics and running something like:

rpk group describe [GROUPS...]

If that level of detail is sufficient, it's possible to remove the high cardinality metric kafka.group_offset, which is what I've done in the default of v3.0.0.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

This isn't intended to be merged as-is, it's more inspiration and PoC

@BenPope BenPope force-pushed the redpanda_consumer_group_lag branch from fb1125f to 814cafd Compare March 20, 2025 13:37
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2025

CLA assistant check
All committers have signed the CLA.

@BenPope BenPope force-pushed the redpanda_consumer_group_lag branch 2 times, most recently from cf13333 to b000319 Compare March 21, 2025 08:24
@BenPope BenPope requested review from hcoyote and tmgstevens March 21, 2025 08:26
@BenPope BenPope self-assigned this Mar 21, 2025
BenPope added 8 commits March 21, 2025 08:37
The tests now pass.

Signed-off-by: Ben Pope <[email protected]>
As of Redpanda v25.1, some consumer group metrics can be disabled
by changing cluster config "enable_consumer_group_metrics".

These are still enabled by default, but split them out into their
own grouping.

Signed-off-by: Ben Pope <[email protected]>
Signed-off-by: Ben Pope <[email protected]>
Signed-off-by: Ben Pope <[email protected]>
@BenPope BenPope force-pushed the redpanda_consumer_group_lag branch from b000319 to 6b6f268 Compare March 21, 2025 08:49
@BenPope BenPope changed the base branch from master to redpanda-3 March 21, 2025 08:58
@@ -15,7 +15,7 @@ services:
- PLAINTEXT://0.0.0.0:9092
- --advertise-kafka-addr
- PLAINTEXT://redpanda:9092
image: docker.redpanda.com/redpandadata/redpanda:${REDPANDA_VERSION}
image: docker.redpanda.com/redpandadata/redpanda-unstable:${REDPANDA_VERSION}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously we need to wait for the release and change this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants