Skip to content

gha: add ECR as registry to push images to #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

gha: add ECR as registry to push images to #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
# list of Docker images to use as base name for tags
images: |
redpandadata/kminion
public.ecr.aws/l9j0i2e0/kminion
# generate Docker tags based on the following events/attributes
# Semver type is only active on 'push tag' events,
# hence no enable condition required
Expand All @@ -47,6 +48,13 @@ jobs:
with:
username: ${{ env.DOCKERHUB_USER }}
password: ${{ env.DOCKERHUB_TOKEN }}
- uses: aws-actions/configure-aws-credentials@v4
with:
aws-region: us-east-1
Copy link
Member Author

@ivotron ivotron Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be us-east-1 as this is the only region that supports public ECR repos

role-to-assume: arn:aws:iam::${{ secrets.RP_AWS_CRED_ACCOUNT_ID }}:role/${{ vars.RP_AWS_CRED_BASE_ROLE_NAME }}${{ github.event.repository.name }}
- uses: aws-actions/amazon-ecr-login@v2
with:
registry-type: public
- uses: docker/build-push-action@v6
with:
provenance: false
Expand Down