Skip to content

Conversation

@dttung2905
Copy link

Hi team,

This PR aims to add more ACL related metrics for kminion, inititally brought up by #137. It will now support 2 different types of metrics

  • Total number of ACLs
  • Total number of ACLs broken down by different type

Below is an example output under /metrics endpoint

# HELP kminion_kafka_acls_by_type The number of ACLs by resource type
# TYPE kminion_kafka_acls_by_type gauge
kminion_kafka_acls_by_type{resource_type="cluster"} 1
kminion_kafka_acls_by_type{resource_type="group"} 2
kminion_kafka_acls_by_type{resource_type="topic"} 3
kminion_kafka_acls_by_type{resource_type="transactional_id"} 4
# HELP kminion_kafka_acls_total The total number of ACLs in the cluster
# TYPE kminion_kafka_acls_total gauge
kminion_kafka_acls_total 10

Signed-off-by: dttung2905 <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Apr 5, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dttung2905
Copy link
Author

Hi @weeco, could you help to take a look at this PR when you have time 🙏 ?

@dttung2905 dttung2905 requested a review from weeco April 24, 2025 21:14
@dttung2905
Copy link
Author

Hi @weeco just want to follow up whether there is anything that I need to do before we can merge this to upstream 🙏 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants