Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.3.x] http/utils: changed url encoding to use upper case hex representation #25188

Open
wants to merge 1 commit into
base: v24.3.x
Choose a base branch
from
Open

[v24.3.x] http/utils: changed url encoding to use upper case hex representation #25188

wants to merge 1 commit into from

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #25168

@mmaslankaprv @vbotbuildovich
http/utils: changed url encoding to use upper case hex representation
a49ef0e 
According to the S3 documentation related with signature calculation the
canonical URI format must be encoded and use the upper case characters
in hexadecimal characters representation.

Document:
https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html

This PR changes the canonical URI encode to use the upper case
hexadecimal representation.

The problem started to occur when a partition key was added as a part of
Iceberg parquet file path. As the path may contain some characters that
require encoding.

Signed-off-by: Michał Maślanka <[email protected]>
(cherry picked from commit 48efe26)
@vbotbuildovich vbotbuildovich added this to the v24.3.x-next milestone Feb 26, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Feb 26, 2025
@vbotbuildovich
Copy link
Collaborator Author

CI test results

test results on build#62346
test_id test_kind job_url test_status passed
rptest.tests.archive_retention_test.CloudArchiveRetentionTest.test_delete.cloud_storage_type=CloudStorageType.S3.retention_type=retention.bytes ducktape https://buildkite.com/redpanda/redpanda/builds/62346#019543a0-5b69-468b-8116-75f3359ada62 FLAKY 1/2
rptest.tests.archive_retention_test.CloudArchiveRetentionTest.test_delete.cloud_storage_type=CloudStorageType.S3.retention_type=retention.ms ducktape https://buildkite.com/redpanda/redpanda/builds/62346#0195438b-057d-4d06-98a9-2771627e6732 FLAKY 1/2
rptest.tests.compaction_recovery_test.CompactionRecoveryTest.test_index_recovery ducktape https://buildkite.com/redpanda/redpanda/builds/62346#019543a0-5b69-4a2d-83e5-46e05fbdea29 FLAKY 1/2
rptest.tests.datalake.compaction_gaps_test.CompactionGapsTest.test_translation_no_gaps.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/62346#0195438b-057c-47aa-a118-88003fcaaa12 FLAKY 1/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaslankaprv mmaslankaprv mmaslankaprv approved these changes

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.3.x-next
Development

Successfully merging this pull request may close these issues.
2 participants
@vbotbuildovich @mmaslankaprv