-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage
: add more log context to continuous_batch_parser::consume_records
#25395
Open
WillemKauf
wants to merge
2
commits into
redpanda-data:dev
Choose a base branch
from
WillemKauf:parser_log_line
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvartolomei
reviewed
Mar 15, 2025
CI test resultstest results on build#63192
test results on build#63196
|
This was being implicitly converted to `std::error_code`.
…records` This `ERROR` log line would be more helpful with added information about the batch consumer type and record batch header. Add a new `ERROR` log line to output these in the cold path.
5da6e28
to
085f754
Compare
Retry command for Build#63196please wait until all jobs are finished before running the slash command
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ERROR
log line we see appearing in thecontinuous_batch_parser
would be more helpful with added information about the batch consumer type and record batch header.Add a new
ERROR
log line to output this additional context in the cold path.Backports Required
Release Notes