Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.2.x] [CORE-8946] cloud_storage: Update process_anomalies method #25396

Open
wants to merge 1 commit into
base: v24.2.x
Choose a base branch
from
Open

[v24.2.x] [CORE-8946] cloud_storage: Update process_anomalies method #25396

wants to merge 1 commit into from

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #25392

@Lazin @vbotbuildovich
cloud_storage: Update process_anomalies method
c387d22 
The current implementation has a bug. If the manifest is empty
the filtering of false positives doesn't work for missing segments.
This commit fixes the problem by filtering out all missing segments
if the manifest is empty or if all segments in the manifest are below
the start offset (which is the same thing).

Signed-off-by: Evgeny Lazin <[email protected]>
(cherry picked from commit dc54c64)
@vbotbuildovich vbotbuildovich added this to the v24.2.x-next milestone Mar 15, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Mar 15, 2025
@vbotbuildovich vbotbuildovich requested a review from Lazin March 15, 2025 06:50
@vbotbuildovich
Copy link
Collaborator Author

vbotbuildovich commented Mar 15, 2025 •
edited
Loading

Retry command for Build#63194

please wait until all jobs are finished before running the slash command


/ci-repeat 1
tests/rptest/tests/retention_policy_test.py::ShadowIndexingCloudRetentionTest.test_cloud_size_based_retention_application@{"cloud_storage_type":2}
tests/rptest/tests/topic_delete_test.py::TopicDeleteCloudStorageTest.topic_delete_unavailable_test@{"cloud_storage_type":2}

@vbotbuildovich
Copy link
Collaborator Author

CI test results

test results on build#63194
test_id test_kind job_url test_status passed
rptest.tests.retention_policy_test.ShadowIndexingCloudRetentionTest.test_cloud_size_based_retention_application.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/63194#019598da-9856-48f3-88a8-756e1fb1634d FAIL 0/1
rptest.tests.topic_delete_test.TopicDeleteCloudStorageTest.topic_delete_unavailable_test.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/63194#019598db-86eb-46bd-b631-010d07926bd3 FAIL 0/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lazin Lazin Awaiting requested review from Lazin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.2.x-next
Development

Successfully merging this pull request may close these issues.
2 participants
@vbotbuildovich @Lazin