Skip to content

chunked_vector: Various improvements #27969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+10 −5
Open

chunked_vector: Various improvements #27969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/v/container/chunked_vector.h
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we static assert this in tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we static assert this in tests?

Yeah, I think there's some more to come, but I'm not full time on it.

Original file line number Diff line number Diff line change
Expand Up @@ -342,12 +342,17 @@ class chunked_vector {
class iter {
public:
using iterator_category = std::random_access_iterator_tag;
using value_type = typename std::conditional_t<C, const T, T>;
using iterator_concept = std::random_access_iterator_tag;
using value_type = T;
using difference_type = std::ptrdiff_t;
using pointer
= std::conditional_t<std::is_same_v<T, bool>, bool, value_type*>;
using reference
= std::conditional_t<std::is_same_v<T, bool>, bool, value_type&>;
using pointer = std::conditional_t<
std::is_same_v<T, bool>,
bool,
std::conditional_t<C, const T*, T*>>;
using reference = std::conditional_t<
std::is_same_v<T, bool>,
bool,
std::conditional_t<C, const T&, T&>>;

iter() = default;

Expand Down
Loading