Client Monitoring: require license + integrate filter #28000
+87
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgellert
requested review from
Copilot and
michael-redpanda
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR integrates filtering functionality and license requirements into the Kafka connections admin API endpoint. The changes enhance security by requiring an enterprise license and improve usability by allowing filtered queries.
- Adds enterprise license validation to the
list_kafka_connectionsendpoint - Integrates AIP filter parser and predicate for connection filtering
- Updates tests to verify both filtering functionality and license enforcement
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/rptest/tests/list_kafka_connections_test.py | Adds tests for filtering integration and license requirement enforcement |
| src/v/redpanda/admin/services/broker.h | Updates constructor to accept feature table dependency for license checking |
| src/v/redpanda/admin/services/broker.cc | Implements license validation and filter integration in list_kafka_connections |
| src/v/redpanda/admin/services/BUILD | Adds dependencies for features, AIP filter, and protobuf RPC |
| src/v/redpanda/admin/server.cc | Updates broker service instantiation to pass feature table |
Integrate the filter parser and predicate into the ListKafkaConnections admin API endpoint.
pgellert
force-pushed
the
cm/filter-integ
branch
from
e4b9a8c to
6e595a8
Compare
|
force-push: address copilot review |
rockwotj
reviewed
Oct 10, 2025
| auto result = connection_gather_result{}; | ||
|
|
||
| auto conn_ptrs = server.list_connections(); | ||
| co_await ss::maybe_yield(); |
There was a problem hiding this comment.
nit: ss::coroutine::maybe_yield()
Comment on lines
134
to
135
| throw serde::pb::rpc::permission_denied_exception( | ||
| fmt::format("Invalid license: {}", status())); |
There was a problem hiding this comment.
Happy to switch to that if you think that's more appropriate, I was debating between the two. I went with permission_denied for consistency with the existing SR ACLs endpoint:
redpanda/src/v/pandaproxy/schema_registry/handlers.cc
Lines 904 to 907 in 1ffde40
There was a problem hiding this comment.
After reading https://grpc.github.io/grpc/core/md_doc_statuscodes.html, failed_precondition seems more appropriate so I've switched to that.
Retry command for Build#73952please wait until all jobs are finished before running the slash command |
This endpoint requires an enterprise license
Carry-over improvement from an earlier PR
Carry-over cleanup from an earlier PR
pgellert
force-pushed
the
cm/filter-integ
branch
from
6e595a8 to
87c8fbb
Compare
|
force-push: change error type + minor fixups from earlier PRs |
rockwotj
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://redpandadata.atlassian.net/browse/CORE-13361
Fixes https://redpandadata.atlassian.net/browse/CORE-13573
Backports Required
Release Notes