http: add xml support to http::mime_types::mappings
#187
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems strange that `xml` isn't supported as a `mime` type here. We expect all S3 REST error responses to be returned with a `Content-Type` header of `application/xml`, so being able to map the extension here makes life a lot easier for testing with imposter `http` S3 servers/services.
rockwotj
approved these changes
Apr 8, 2025
Opened scylladb#2725 |
|
My upstream PR sparked good discussion on the seastar side of things, so we now have a better patch on the way: scylladb@c7e79b8 |
Yes, this is common: my feeling is that unless (wall clock) time is really at a premium it's better to upstream first, then downstream the commits (optionally), as it leads to less overall churn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems strange that
xmlisn't supported as amimetype here. We expect all S3 REST error responses to be returned with aContent-Typeheader ofapplication/xml, so being able to map the extension here makes life a lot easier for testing with imposterhttpS3 servers/services.Motivated by having to fix tests for redpanda-data/redpanda#25738.