posix-stack: add null check #244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds assert to the on-ramps to net::packet UB. This commit changes posix_data_sink_impl to guard against concurrency problems by asserting that its contained net::packet is null before accepting another. changes: net_packet now initialized as a null packet instead of a default packet added assert to put(net::packet) that checks the contained packet is null write_all can throw, change the packet reset to occur regardless of exceptions
There was a problem hiding this comment.
Pull Request Overview
This PR addresses potential concurrency issues in posix_data_sink_impl by adding safeguards to prevent misuse of the internal net::packet member. The changes ensure that the packet member is properly initialized and not overwritten while in use.
Key Changes:
- Added assertion to verify packet state before accepting new data
- Changed packet initialization from default to explicit null packet
- Improved exception safety by using
finallyinstead ofthenfor cleanup
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| include/seastar/net/posix-stack.hh | Initializes _p member as null packet to ensure proper initial state |
| src/net/posix-stack.cc | Adds assertion to guard against concurrent packet writes and improves cleanup exception safety |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Attempting to upstream instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds assert to the on-ramps to net::packet UB.
This commit changes posix_data_sink_impl to guard against concurrency problems by asserting that its contained net::packet is null before accepting another.
changes:
net_packet now initialized as a null packet instead of a default packet added assert to put(net::packet) that checks the contained packet is null
write_all can throw, change the packet reset to occur regardless of exceptions