Byovpc gcp #213
Draft
Byovpc gcp #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I apologize in advance for what you're going to see in this commit. So basically the terraform acceptance testing framework for the terraform plugin framework doesn't support the use of terraform modules. Yes, you read that right. In this context "doesn't support" means "will not delete any of the resources created by a module if the test fails". The module in question creates hundreds of resources so this isn't an ideal outcome. As a result I split the module out to a separate file and imported the arns of the essential created resources. This isn't ideal and isn't how end users should do this. I'm not sure how to square the circle on this one. # Conflicts: # examples/byovpc/aws/main.tf
Also adds an email validator as that seemed sensible. I moved the aws elements of the cmr generate function into helper functions to improve readability of that enormous switch. I still need to add in the update support for CMR related stuff.
gene-redpanda
force-pushed
the
byovpc-gcp
branch
from
b92d802 to
b191651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.