Open
Conversation
The invocation of the time vsyscall produces a segfault when built using a toolchain that produces position independent executables by default. This is because the inline asm produces an RIP-relative call whose offset does not get adjusted by the dynamic linker. Fix this by eliminating the vsyscall wrapper and defining vsyscall_time to be a pointer to the fixed vsyscall address. Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The invocation of the time vsyscall produces a segfault when
built using a toolchain that produces position independent
executables by default. This is because the inline asm produces
an RIP-relative call whose offset does not get adjusted by the
dynamic linker.
Fix this by eliminating the vsyscall wrapper and defining
vsyscall_time to be a pointer to the fixed vsyscall address.
Signed-off-by: Seth Forshee seth.forshee@canonical.com