(#164) Serde improvements, open_binary -> files changes

[vjanelle]

Makes it when you use object conditionals that serde/deser works, as opposed to using the raw dict literals.

Update API usage for picked data to use the files() api.

[redruin1]

The open_binary to files change seems like a good idea, although after doing a bit of research it seems that pkg_resources itself might be being deprecated in favor of importlib.resources in Python > 3.12. Would it be a good idea to use that instead?

For the other changes, does the fix described here take care of your expected behavior? From what I've gleaned from the commits it seems Pydantic should take care of most if this stuff on the backend when the types are properly annotated, unless there's some additional behavior being added here that I'm not seeing.

[vjanelle]

Importlib.resources was added in 3.7, so should be fine?

Is there a minimum python version this project is targeting?

[redruin1]

Yes, sounds good. Since Draftsman 2.0 we depend on type annotations, so Python 3.7 is our minimum version going forward.

[vjanelle]

Ah, ok. With some of the pedantic stuff here I think the minimum is actually 3.10, but only if people use the objects features

…

On Mon, May 12, 2025 at 12:03 PM redruin1 ***@***.***> wrote: *redruin1* left a comment (redruin1/factorio-draftsman#165) <#165 (comment)> Yes, sounds good. Since Draftsman 2.0 we depend on type annotations, so Python 3.7 is our minimum version going forward. — Reply to this email directly, view it on GitHub <#165 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFTDSIKEJOGDW2MIMKWAWT26DWBJAVCNFSM6AAAAAB44XCPE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNZTGY4TEOBYGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>