18 benchmark ros2 reduct agent and rosbag2 #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyCvn
requested changes
Jul 13, 2025
Member
AnthonyCvn
left a comment
AnthonyCvn
left a comment
There was a problem hiding this comment.
Thanks for the initial benchmarking setup; looks solid !
A few suggestions:
- 🔄 Instead of using a
.ipynb, please create abenchmark.pyscript and make it interactive using# %%cells. This will keep it notebook-friendly while being easier to version and execute in VS Code or other editors. - 📦 Use the following link to download the test dataset (public link on our google drive):
https://drive.google.com/file/d/1gaQSR3mhrhTSSjqdcu8M-kdCHiwh4d4J
And please add*.mcapto the.gitignoreso the file isn't committed. + you can add the YAML file in the repo (and update the paths like "/home/ekaterina/Downloads/" to relative import like "./benchmark/...") - ✅ The current benchmarking logic is good; however, we only need to compare with
--compression-mode=messageinrosbag2. File compression is not supported with the agent. - 📊 For the
ros2_reduct_agentbenchmarks, also include system resource monitoring for ReductStore. This way, we're comparingrosbag2 recordvsagent + reductstore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added benchmark folder with a benchmark for ros2 reduct agent vs. rosbag2.