3 minimum recording implementation #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an initial implementation of a minimum recording feature for ROS2 that records selected topics to ReductStore. Key changes include new tests for topic subscriptions, storage and SI unit parsing, a new Recorder node with MCAP-based message recording and pipeline configuration, and updates to project configuration and launch files.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/* | Unit tests added for topic subscriptions, storage operations, SI parsing, and recorder state management. |
| ros2_reduct_agent/recorder.py | New Recorder node implementation including pipeline management and MCAP writer integration. |
| ros2_reduct_agent/config_models.py | New configuration models and SI unit parsing validations for storage and pipelines. |
| setup.py, launch files, README.md, CI configs | Miscellaneous project configuration updates and documentation improvements. |
Comments suppressed due to low confidence (1)
test/test_recorder_state.py:43
- [nitpick] The magic number '203' used to calculate the expected size is unclear; consider documenting its origin or replacing it with a named constant to improve clarity.
assert low_chunk_recorder.pipeline_states["timer_test_topic"].current_size == 5 * (size_kb * 1024 + 203)
atimin
requested changes
May 27, 2025
Member
|
@AnthonyCvn , very impressive work! Few comments from my side. I think some of them are separate tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
feature
What was changed?
Initial release of minimum recorder
Related issues
Documentation: reductstore/website#196
Does this PR introduce a breaking change?
No
Other information: