Skip to content

Fix Errors when running npm test on sagas branch after following tutorial #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sagas
Choose a base branch
from

Conversation

lilrogalski
Copy link

I was following along with the beginner tutorial when I realized that running npm test on the sagas branch throws the following error:

$ npm test

> [email protected] test /Users/ryan/sites/redux-saga-beginner-tutorial
> babel-node sagas.spec.js | tap-spec


  incrementAsync Saga test

/Users/ryan/sites/redux-saga-beginner-tutorial/node_modules/@redux-saga/core/dist/io-1d6eccda.js:37
    throw new Error(error);
    ^

Error: call: argument fn is undefined or null
    at check (/Users/ryan/sites/redux-saga-beginner-tutorial/node_modules/@redux-saga/core/dist/io-1d6eccda.js:37:11)
    at validateFnDescriptor (/Users/ryan/sites/redux-saga-beginner-tutorial/node_modules/@redux-saga/core/dist/io-1d6eccda.js:459:3)
    at call (/Users/ryan/sites/redux-saga-beginner-tutorial/node_modules/@redux-saga/core/dist/io-1d6eccda.js:528:5)
    at Test.<anonymous> (/Users/ryan/sites/redux-saga-beginner-tutorial/sagas.spec.js:12:5)
    at Test.bound [as _cb] (/Users/ryan/sites/redux-saga-beginner-tutorial/node_modules/tape/lib/test.js:80:32)
    at Test.run (/Users/ryan/sites/redux-saga-beginner-tutorial/node_modules/tape/lib/test.js:96:10)
    at Test.bound [as run] (/Users/ryan/sites/redux-saga-beginner-tutorial/node_modules/tape/lib/test.js:80:32)
    at Immediate.next (/Users/ryan/sites/redux-saga-beginner-tutorial/node_modules/tape/lib/results.js:83:19)
    at processImmediate (internal/timers.js:439:21)
    at process.topLevelDomainCallback (domain.js:126:23)


npm ERR! Test failed.  See above for more details

This PR simply updates the imports so the tests work.

Copy link

@REX500 REX500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't fix it for me tho...
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants