Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds argument to prevent Redux DevTool CLI disconnecting when debugging #1622

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/redux-devtools-cli/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Change Log

## 4.1.0

### Minor changes

- adds CLI argument to change ping timeout `--pingTimeout=20000` to make debugging easier
- fixes `--maxRequestBody` argument

## 4.0.0

### Major Changes
Expand Down
1 change: 1 addition & 0 deletions packages/redux-devtools-cli/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ To use WSS, set `protocol` argument to `https` and provide `key`, `cert` and `pa
| `--logLevel` | the socket server log level - 0=none, 1=error, 2=warn, 3=info | 3 |
| `--wsEngine` | the socket server web socket engine - ws or uws (sc-uws) | ws |
| `--open` | open Redux DevTools as a standalone application or as web app. See [Open Redux DevTools](#open-redux-devtools) for details. | false |
| `--pingTimeout` | if debugged app is not responding for 20 seconds (because it paused on breakpoint) the Redux DevTools will disconnect. This can extend it to e.g. 8 hours `28000000`ms | 20000 |

### Inject to React Native local server

Expand Down
2 changes: 1 addition & 1 deletion packages/redux-devtools-cli/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@redux-devtools/cli",
"version": "4.0.0",
"version": "4.1.0",
"description": "CLI for remote debugging with Redux DevTools.",
"homepage": "https://github.com/reduxjs/redux-devtools/tree/master/packages/redux-devtools-cli",
"bugs": {
Expand Down
4 changes: 3 additions & 1 deletion packages/redux-devtools-cli/src/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export interface Options {
dbOptions: DbOptions;
maxRequestBody: string;
logHTTPRequests?: boolean;
pingTimeout: number;
logLevel: 0 | 1 | 3 | 2;
wsEngine: string;
}
Expand Down Expand Up @@ -59,9 +60,10 @@ export default function getOptions(argv: { [arg: string]: any }): Options {
undefined,
},
dbOptions: dbOptions,
maxRequestBody: argv.passphrase || '16mb',
maxRequestBody: argv.maxRequestBody || '16mb',
logHTTPRequests: argv.logHTTPRequests,
logLevel: argv.logLevel || 3,
pingTimeout: argv.pingTimeout || 20000,
wsEngine:
argv.wsEngine || process.env.npm_package_remotedev_wsengine || 'ws',
};
Expand Down
Loading