-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
codegen: Add exactOperationIds option to generateEndpoints config
#5174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
issy
wants to merge
16
commits into
reduxjs:master
Choose a base branch
from
issy:exact-operation-ids
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2dd410d
JSDoc stuff
issy cd2b656
Add `exactOperationIds` config option
issy 91ba30d
Use `exactOperationIds` in codegen to not mangle operation IDs when g…
issy 09bf8b2
Merge branch 'master' into exact-operation-ids
issy 8084329
Fix
issy a2ed8a3
Ordering
issy 46c4b5c
More ordering
issy 873ebdc
Add test stubs
issy 431ad22
Add duplicate operation ID check
issy 7fb5712
Remove temporary workaround as no longer needed
issy 34e6137
Implement tests
issy b2ab805
Better error message
issy 133d11b
Extract
issy 90f9c35
Add note to docs
issy 1433fea
Add JSDoc description
issy 561ce40
Add function overloads
issy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also including this slightly off-topic change here. This allows the return type of the function (
stringorvoid) to be inferred based on whetheroutputFileis passed. Without this, I have to doawait generateEndpoints(...) as stringin my codegen setup.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. So
outputFile→void, and nooutputFile→string, correct? If that's expected behavior, the types should reflect it more cleanly. I'll open a small follow-up PR for this. Thanks for flagging!