fix(query): prevent onQueryStarted from triggering at end-of-list#5182
Open
joseph0926 wants to merge 2 commits intoreduxjs:masterfrom
Open
fix(query): prevent onQueryStarted from triggering at end-of-list#5182joseph0926 wants to merge 2 commits intoreduxjs:masterfrom
joseph0926 wants to merge 2 commits intoreduxjs:masterfrom
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 475a8e3:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
The tests added in the previous commit seemed slightly insufficient, so I added additional test code for possible edge cases. For example, while only forward testing existed before, this commit adds verification for backward cases, as well as handling for skip operations and null values.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5167
Summary
When
fetchNextPage()orfetchPreviousPage()is called at end-of-list (whengetNextPageParam/getPreviousPageParamreturnsundefined), the thunk was still executing and triggeringonQueryStartedwith stale cached data.To solve the problem added an early bail-out in the thunk's
conditionfunction -> to check if the next/previous page actually exists before processing any action.Changes
buildThunks.tscondition functionisFetchingPreviousPage: truewhen no previous page exists)Test