chore(toolkit): remove redundant and unused type declarations - #5356
Open
aryaemami59 wants to merge 1 commit into
Open
chore(toolkit): remove redundant and unused type declarations#5356aryaemami59 wants to merge 1 commit into
aryaemami59 wants to merge 1 commit into
Conversation
- remove a duplicate overload from `ConditionFunction`
- return `TypedCreateListenerEntry` instead of `TypedStopListening` from `TypedCreateListenerEntry.withTypes()`
- fold the trailing `& { effect }` intersection into `FallbackAddListenerOptions`
- remove the redundant leading `RefetchConfigOptions &` from `ConfigState`, which `ModifiableConfigState` already intersects
- remove the unused generic type parameter from `AnyQueryActionCreator`
aryaemami59
added
RTK-Query
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@reduxjs/rtk-codemods
@rtk-query/codegen-openapi
@rtk-query/graphql-request-base-query
@reduxjs/toolkit
commit: |
aryaemami59
marked this pull request as ready for review
August 4, 2026 02:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConditionFunctionTypedCreateListenerEntryinstead ofTypedStopListeningfromTypedCreateListenerEntry.withTypes()& { effect }intersection intoFallbackAddListenerOptionsRefetchConfigOptions &fromConfigState, whichModifiableConfigStatealready intersectsAnyQueryActionCreator