chore: exclude build artifacts from tsconfig and add legacy_createSto…#4844
chore: exclude build artifacts from tsconfig and add legacy_createSto…#4844Divyapahuja31 wants to merge 2 commits intoreduxjs:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
If we're going to do this, I'd rather have the existing (tbh I also don't think we necessarily need tests for |
|
Agreed.
It's a simple alias/re-export, so dedicated tests don't seem necessary. |
|
Thanks for the clarification, that makes sense. I agree that dedicated tests for legacy_createStore aren’t really needed since it’s just an alias and has been stable for a long time. I’ll remove the standalone test file and updated the PR accordingly. |
Description
This PR addresses two maintenance issues to improve repository health and developer experience:
Added tests for
legacy_createStore:legacy_createStoreexport was previously uncovered by tests, leaving a gap in coverage forcreateStore.ts.test/legacy_createStore.spec.tsto verify the legacy alias functions correctly and exposes the same public API ascreateStore.createStore.tsto 100%.Updated
tsconfig.jsonexclusions:yarn test(which triggersvitest --typecheck) would fail with hundreds of type errors if thewebsite/,examples/, orcoverage/directories were present (e.g., after building the site or running coverage). This was because the root TypeScript config was attempting to check these directories which have their own unrelated configurations.website,examples,docs, andcoverageto theexcludelist intsconfig.json.yarn testnow passes cleanly regardless of the state of these folders.Fixed missing dependency:
@vitest/coverage-v8was missing. I added it todevDependencies.Type of change
Checklist