fix(dtu): replace execa with node:child_process#66
Merged
Conversation
Build and execute the released binary as part of smoke tests: verify shebang is correct, run built binary directly via node, and run built binary via npx (simulates npx install). Catches shebang issues, broken imports, and bin-field misconfigurations before publishing.
execa was in devDependencies but imported in production code, causing ERR_MODULE_NOT_FOUND when running via npx. Replaced with Node's built-in child_process.exec and removed execa entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
execawas listed indevDependenciesbut imported in production code (src/server/index.ts). When running vianpx, devDependencies aren't installed, causing:Fix
Replaced the single
execacall with Node's built-inchild_process.exec. It was only used to kill a stale process on the DTU port. RemovedexecafromdevDependenciesentirely (-16 packages from the tree).