Skip to content

fix: prevent layer prototype staleness causing isLayer checks to fail #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
airslice merged 1 commit into from
Apr 3, 2026
Merged

fix: prevent layer prototype staleness causing isLayer checks to fail #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/Map/Layers/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,12 @@ export default function useHooks({
),
);

// Store getComputedLayer in a ref to avoid recreating prototypes on every change
const getComputedLayerRef = useRef(getComputedLayer);
useEffect(() => {
getComputedLayerRef.current = getComputedLayer;
}, [getComputedLayer]);

const lazyComputedLayerPrototype = useMemo<object>(() => {
return objectFromGetter(
// id and layer should not be accessible
Expand All @@ -212,12 +218,12 @@ export default function useHooks({
const id: string | undefined = (this as any).id;
if (!id || typeof id !== "string") throw new Error("layer ID is not specified");

const layer = getComputedLayer(id);
const layer = getComputedLayerRef.current(id);
if (!layer) return undefined;
return (layer as any)[key];
},
);
}, [getComputedLayer]);
}, []);

const lazyLayerPrototype = useMemo<object>(() => {
return objectFromGetter(layerKeys, function (key) {
Expand All @@ -237,7 +243,7 @@ export default function useHooks({
else if (key === "isVisible") return layer.visible;
// computed
else if (key === "computed") {
const computedLayer = getComputedLayer(layer.id);
const computedLayer = getComputedLayerRef.current(layer.id);
if (!computedLayer) return undefined;
const computed = Object.create(lazyComputedLayerPrototype);
computed.id = id;
Expand All @@ -246,7 +252,7 @@ export default function useHooks({

return (layer as any)[key];
});
}, [getComputedLayer, layerMap, lazyComputedLayerPrototype]);
}, [layerMap, lazyComputedLayerPrototype]);

const findById = useCallback(
(layerId: string): LazyLayer | undefined => {
Expand Down
Loading