fix: update 3dtiles feature color value when selected and style changed - #87
Merged
airslice merged 2 commits intoAug 8, 2025
Conversation
keiya01
approved these changes
Aug 8, 2025
ZTongci
approved these changes
Aug 8, 2025
airslice
deleted the
fix/threed-tile-feature-color-update-incorrectly-when-selected
branch
August 8, 2025 07:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Previous code handled the 3dtiles feature color update when
isFeatureSelectedas:isFeatureSelecteduseselectedFeatureColororraw.colorand returned.This works fine if the update is coming from select only, the color will switch between
selectedFeatureColorandraw.colorwhen select/unselect feature.However there's another case, when override style while the feature is also selected. in this case the new color was ignored. raw.color has no chance to be updated to the expect one.
I fix the update order as:
Please ignore the changes around line 95-103 and 762-788, they're coming from auto format.