Skip to content

chore(server): Revert RemoveAsset debug #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hexaforce merged 2 commits into from
May 14, 2025
Merged

chore(server): Revert RemoveAsset debug #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43431c4
Revert "chore(server): RemoveAsset debug (#57)"
hexaforce Apr 16, 2025
341f9ea
Merge branch 'main' into revert/remove-asset-debug
hexaforce May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions server/internal/infrastructure/gcs/file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ func (f *fileRepo) RemoveAsset(ctx context.Context, u *url.URL) error {
if sn == "" {
return gateway.ErrInvalidFile
}
fmt.Println("----------------- RemoveAsset")
return f.delete(ctx, sn)
}

Expand Down Expand Up @@ -298,23 +297,18 @@ func (f *fileRepo) move(ctx context.Context, from, dest string) error {
}

func (f *fileRepo) delete(ctx context.Context, filename string) error {
fmt.Println("----------------- delete1")
if filename == "" {
return gateway.ErrInvalidFile
}
fmt.Println("----------------- delete2")

bucket, err := f.bucket(ctx)
if err != nil {
log.Errorfc(ctx, "gcs: delete bucket err: %+v\n", err)
return rerror.ErrInternalByWithContext(ctx, err)
}

fmt.Println("----------------- delete3")
object := bucket.Object(filename)
fmt.Println("----------------- delete3 object.BucketName():", object.BucketName())
fmt.Println("----------------- delete3 object.ObjectName():", object.ObjectName())
if err := object.Delete(ctx); err != nil {
fmt.Println("----------------- delete3 err.Error():", err.Error())
if errors.Is(err, storage.ErrObjectNotExist) {
return nil
}
Expand Down
Loading