Skip to content

Conversation

@renovate
Copy link

@renovate renovate bot commented May 21, 2025

This PR contains the following updates:

Package Change Age Confidence
go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho v0.32.0v0.44.0 age confidence

GitHub Vulnerability Alerts

CVE-2023-45142

Summary

This handler wrapper https://github.com/open-telemetry/opentelemetry-go-contrib/blob/5f7e6ad5a49b45df45f61a1deb29d7f1158032df/instrumentation/net/http/otelhttp/handler.go#L63-L65
out of the box adds labels

  • http.user_agent
  • http.method

that have unbound cardinality. It leads to the server's potential memory exhaustion when many malicious requests are sent to it.

Details

HTTP header User-Agent or HTTP method for requests can be easily set by an attacker to be random and long. The library internally uses httpconv.ServerRequest that records every value for HTTP method and User-Agent.

PoC

Send many requests with long randomly generated HTTP methods or/and User agents (e.g. a million) and observe how memory consumption increases during it.

Impact

In order to be affected, the program has to configure a metrics pipeline, use otelhttp.NewHandler wrapper, and does not filter any unknown HTTP methods or User agents on the level of CDN, LB, previous middleware, etc.

Others

It is similar to already reported vulnerabilities

Workaround for affected versions

As a workaround to stop being affected otelhttp.WithFilter() can be used, but it requires manual careful configuration to not log certain requests entirely.

For convenience and safe usage of this library, it should by default mark with the label unknown non-standard HTTP methods and User agents to show that such requests were made but do not increase cardinality. In case someone wants to stay with the current behavior, library API should allow to enable it.

The other possibility is to disable HTTP metrics instrumentation by passing otelhttp.WithMeterProvider option with noop.NewMeterProvider.

Solution provided by upgrading

In PR https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277, released with package version 0.44.0, the values collected for attribute http.request.method were changed to be restricted to a set of well-known values and other high cardinality attributes were removed.

References


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from pyshx as a code owner May 21, 2025 07:05
@renovate renovate bot added the security label May 21, 2025
@coderabbitai
Copy link

coderabbitai bot commented May 21, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link

netlify bot commented May 21, 2025

Deploy Preview for reearth-classic canceled.

Name Link
🔨 Latest commit d3c0b07
🔍 Latest deploy log https://app.netlify.com/projects/reearth-classic/deploys/682d7b3d4ed1f20008c89448

@renovate renovate bot force-pushed the renovate/go-go.opentelemetry.io-contrib-instrumentation-github.com-labstack-echo-otelecho-vulnerability branch from d3c0b07 to d4fd0b2 Compare August 11, 2025 04:05
@renovate renovate bot force-pushed the renovate/go-go.opentelemetry.io-contrib-instrumentation-github.com-labstack-echo-otelecho-vulnerability branch from d4fd0b2 to 582ced6 Compare September 26, 2025 00:03
@renovate renovate bot force-pushed the renovate/go-go.opentelemetry.io-contrib-instrumentation-github.com-labstack-echo-otelecho-vulnerability branch 3 times, most recently from 5a3a523 to 202f4a5 Compare November 27, 2025 08:20
@renovate renovate bot requested a review from soneda-yuya as a code owner November 27, 2025 08:20
@renovate renovate bot force-pushed the renovate/go-go.opentelemetry.io-contrib-instrumentation-github.com-labstack-echo-otelecho-vulnerability branch 7 times, most recently from 6329ad9 to ba21f73 Compare December 5, 2025 06:15
@renovate renovate bot force-pushed the renovate/go-go.opentelemetry.io-contrib-instrumentation-github.com-labstack-echo-otelecho-vulnerability branch from ba21f73 to 67542c3 Compare December 19, 2025 01:46
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 23.79%. Comparing base (703e022) to head (4a521eb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   23.80%   23.79%   -0.01%     
==========================================
  Files        1587     1588       +1     
  Lines      170092   170141      +49     
  Branches     2801     2801              
==========================================
  Hits        40486    40486              
- Misses     128439   128488      +49     
  Partials     1167     1167              
Flag Coverage Δ
server 32.02% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@renovate renovate bot force-pushed the renovate/go-go.opentelemetry.io-contrib-instrumentation-github.com-labstack-echo-otelecho-vulnerability branch from 67542c3 to 4a521eb Compare December 24, 2025 05:59
@renovate renovate bot force-pushed the renovate/go-go.opentelemetry.io-contrib-instrumentation-github.com-labstack-echo-otelecho-vulnerability branch from 4a521eb to b4d41f7 Compare January 7, 2026 04:50
…ub.com/labstack/echo/otelecho to v0.44.0 [security]
@renovate renovate bot force-pushed the renovate/go-go.opentelemetry.io-contrib-instrumentation-github.com-labstack-echo-otelecho-vulnerability branch from b4d41f7 to 2536657 Compare January 8, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant