Skip to content

fix(ui): set defaultValue to null for empty strings in workflow variable creation and updates [FLOW-DEV-30] #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
billcookie wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

fix(ui): set defaultValue to null for empty strings in workflow variable creation and updates [FLOW-DEV-30] #2017

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6ee4aee
fix(ui): set defaultValue to null for empty strings in workflow varia…
billcookie Mar 25, 2026
4b3945a
Merge branch 'main' into FLOW-UI-30
billcookie Mar 25, 2026
ecf15c4
fix(ui): add helper function
billcookie Mar 25, 2026
9cb0de5
fix(ui): change from arrow to function
billcookie Mar 25, 2026
02dbf10
Merge branch 'FLOW-UI-30' of github.com:reearth/reearth-flow into FLO…
billcookie Mar 25, 2026
a7345ee
Merge branch 'main' into FLOW-UI-30
billcookie Mar 30, 2026
c340952
Merge branch 'main' into FLOW-UI-30
billcookie Mar 31, 2026
cee01eb
Merge branch 'main' into FLOW-UI-30
billcookie Apr 3, 2026
667af31
Merge branch 'main' into FLOW-UI-30
billcookie Apr 8, 2026
4a425e9
Merge branch 'main' into FLOW-UI-30
billcookie Apr 13, 2026
27c96ff
Merge branch 'main' into FLOW-UI-30
billcookie May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions ...ditor/components/OverlayUI/components/Homebar/components/WorkflowVariablesDialog/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,13 @@ export default ({
}
}, [currentWorkflowVariables, getUserFacingName]);

function defaultValueConversion(variable: WorkflowVariable) {
return {
...variable,
defaultValue: variable.defaultValue === "" ? null : variable.defaultValue,
};
}

const handleLocalAdd = useCallback(
(type: VarType) => {
const tempId = `temp_${generateUUID()}`;
Expand Down Expand Up @@ -256,7 +263,9 @@ export default ({
) {
const creates = addChanges.map((change) => ({
name: change.workflowVariable.name,
defaultValue: change.workflowVariable.defaultValue,
defaultValue: defaultValueConversion(change.workflowVariable)
.defaultValue,

config: change.workflowVariable.config,
type: change.workflowVariable.type,
required: change.workflowVariable.required,
Expand All @@ -267,7 +276,8 @@ export default ({
const updates = updateChanges.map((change) => ({
paramId: change.workflowVariable.id,
name: change.workflowVariable.name,
defaultValue: change.workflowVariable.defaultValue,
defaultValue: defaultValueConversion(change.workflowVariable)
.defaultValue,
config: change.workflowVariable.config,
type: change.workflowVariable.type,
required: change.workflowVariable.required,
Expand All @@ -290,11 +300,11 @@ export default ({
});
} else {
for (const change of addChanges) {
await onAdd(change.workflowVariable);
await onAdd(defaultValueConversion(change.workflowVariable));
}

for (const change of updateChanges) {
await onChange(change.workflowVariable);
await onChange(defaultValueConversion(change.workflowVariable));
}

if (deleteChanges.length > 0) {
Expand Down
Loading