feat(engine): forcing default values for schema and rigid dynamic port support#2019
Draft
shunski wants to merge 3 commits into
Draft
feat(engine): forcing default values for schema and rigid dynamic port support#2019shunski wants to merge 3 commits into
shunski wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The aim of this PR is to let factory's port functions (
get_input_ports()/get_output_ports()) to consider the ports that can only be determined at the beginning of runtime (i.e. DAG build time).To this end we will adapt to the convention that all parameters of action implement the default value for the action schema generation. Assuming this, factory's port functions can now depend on the
withparameter for the dynamic ports, and it uses the default values for the schema to fill out the port information during the schema generation.What I've done
withparameter as an argument, so that the dynamic ports can be reported by these functions.OutputRouterandFeatureFilter, so look at their implementation for how dynamic ports are reported by these functions.What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
Memo