-
Notifications
You must be signed in to change notification settings - Fork 9
feat(engine/sink)!: require relative paths in sink output #2123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
0b5fc78
test(engine/sink): add unit tests for strict-relative chokepoint
bnimit 67cf8ce
feat(engine/sink)!: require relative paths in sink output
bnimit bae7f83
chore: gitignore .local-specs/
bnimit 7008ff5
chore(engine/fixtures): migrate workflow YAML to relative sink paths
bnimit 51428d8
test(engine): integration tests for relative sink output path
bnimit 9c901cc
docs(engine): update Sandbox & sink writes section for relative paths
bnimit f496e3f
docs: changelog entry for relative sink-output paths
bnimit bbb08bf
chore(engine): bump workspace version to 0.0.376
bnimit 483c5b9
style: cargo fmt
bnimit 74555a6
fix(engine/fixtures): address PR #2123 review feedback
bnimit 3900491
chore(engine/examples): regenerate plateau workflow YAMLs
bnimit 681a53d
chore: re-trigger CI after PR review fixes
bnimit 11643b9
merge: main into chore/sink-relative-paths
bnimit e27955e
fix(engine/sink): route cesium3dtiles + mvt buffer keys through SinkO…
bnimit a454c76
fix(engine/test): plateau-tiles-test uses run_with_sandbox_root
bnimit 34af8c0
style: cargo fmt
bnimit cf16250
refactor(engine/sink): extract ensure_relative_path helper
bnimit cef62f7
refactor(engine/sink): make SinkOutput::from_resolved_uri pub(crate)
bnimit f786803
refactor(engine/sink): unify SinkOutput around new(sandbox_root, path…
bnimit a6aa0bb
docs(engine): update Sandbox & sink writes section for unified API
bnimit 77253ad
style: cargo fmt
bnimit 4fad127
refactor(engine/sink): remove ensure_valid_relative_path
bnimit 554b8e7
Merge branch 'main' into chore/sink-relative-paths
bnimit 8a52598
chore(engine): bump workspace version to 0.0.378
bnimit 390ac37
chore(engine/fixtures): migrate PLATEAU6 quality-check fixtures to re…
bnimit b38f176
docs(engine): clarify per-sink portability across storage backends
bnimit 74a742a
docs(engine): remove Sandbox & sink writes section from AGENTS.md
bnimit ec1f0f2
error log
asrcpq 4d8d4db
log before null fallback
asrcpq eeba0e2
fix(engine/sink): make sandbox-root prefix-strip a hard error
bnimit 0cb8832
Revert "log before null fallback"
asrcpq feab4f0
Revert "error log"
asrcpq 2a6dc72
Merge branch 'main' into chore/sink-relative-paths
bnimit 80cfbd2
chore(engine/sink): drop CHANGELOG entry and .local-specs gitignore line
bnimit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,3 +5,4 @@ | |
| reearth-flow-websocket/ | ||
| reearth-flow-websocket-rs/ | ||
| target/ | ||
| .local-specs/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.