馃悰 Patch nbsp issue - #67
Merged
Merged
Conversation
thetomnewton
force-pushed
the
patch-nbsp-issue
branch
from
May 6, 2026 12:44
22b6417 to
4e01686
Compare
alecgibson
reviewed
May 6, 2026
alecgibson
left a comment
alecgibson
left a comment
Collaborator
There was a problem hiding this comment.
Ooof. For reference, here's the issue tracking this: slab#4509
Don't forget to bump the version please.
thetomnewton
force-pushed
the
patch-nbsp-issue
branch
from
May 6, 2026 15:27
4e01686 to
db05064
Compare
thetomnewton
force-pushed
the
patch-nbsp-issue
branch
from
May 6, 2026 15:29
db05064 to
eaa44be
Compare
alecgibson
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Quill added a replaceAll for spaces to be converted to
. The consequence for us is that when a user pastes their chapter content elsewhere such as Word, Word has no place to wrap the content since there are no spaces in the sentences, so it simply breaks the words as the only thing left it can do. The user has to literally retype each sentence to fix this, or paste it elsewhere first to revert thenbsps back to spaces.I propose we revert this change back to how it worked previously, until Quill fixes this upstream and we defer to the fix.
The offending PR: (in a code block since this repo is public)
https://github.com/slab/quill/pull/4502Tested this locally by temp patching my
node_modulesinreedsy-editorand confirmed that it worked.