-
Notifications
You must be signed in to change notification settings - Fork 0
docs(search): response fieldes added, descriptions changed #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Aleksandr Zavadkin <[email protected]>
Signed-off-by: Aleksandr Zavadkin <[email protected]>
Signed-off-by: Aleksandr Zavadkin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Указал на недочёты в структуре ответа. Надо дополнительно проверить структуры остальных агрегаций, по тому же PR, который кидал
source/includes/_search.md.erb
Outdated
| | | * `image_url_resized` (object) | | ||
| | | * `url_handle`(string) | | ||
| | | * `group_id`(string) | | ||
| | | * `_id` (string) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Здесь далеко не все поля внутри товара. Можно внимательнее посмотреть на структуру возвращаемого товара:
https://api-r46.halykmarket.kz/search?did=i6lyFZgSBK&shop_id=693ff081028570920fd8a6b971eb5e&sid=QJXwkaufPo&type=full_search&search_query=Пудра-бронзер&excluded_merchants=Perfume Home&locations=-1&excluded_brands=dior,estee lauder
А наиболее актуальную информацию по всем типам и форматам полей можно найти тут:
https://github.com/rees46/services/pull/32/files#diff-57a5ae4d5edcc6a24b9a99c89a3ac74c6aa962211fae79b15c5bd3ad1c190b94R1
source/includes/_search.md.erb
Outdated
| | | * `name` (string) | | ||
| | | * `parent` (string) | | ||
| | | * `url_handle` (string) | | ||
| | | * `count` (integer) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тоже не все поля. Полная структура тут: https://github.com/rees46/services/pull/32/files#diff-c5ad25c1ea0dd888a69b20338e7a31adada654fe80cb546d955a7a6f3a919323R1
source/includes/_search.md.erb
Outdated
| image_url_resized | object | Object with resized images | | ||
| url_handle | string | Relative product URL | | ||
| group_id | string | ID of product group (aggregated variations) | | ||
| _id | string | Internal ID | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
изменить исходя из комментариев выше
source/includes/_search.md.erb
Outdated
| url | string | Full URL to category | | ||
| parent | string | ID of the parent category | | ||
| url_handle | string | Relative URL path to the category | | ||
| count | integer | Number of products in this category | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
изменить исходя из комментариев выше
Signed-off-by: Aleksandr Zavadkin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Всё равно там не все возможные поля описаны. Я кидал ссылку на PR. Там есть все актуальные поля и их типы.
Пример для товара:
gift
,
installment
....
https://github.com/rees46/development/issues/2242
Пруф