Skip to content

docs(search): response fieldes added, descriptions changed #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gochicus
Copy link
Contributor

@gochicus gochicus commented Dec 23, 2024

@gochicus gochicus added the documentation Improvements or additions to documentation label Dec 23, 2024
@gochicus gochicus self-assigned this Dec 23, 2024
@gochicus gochicus requested a review from davidgegiya May 27, 2025 10:21
@gochicus gochicus marked this pull request as ready for review May 27, 2025 10:21
Copy link

@davidgegiya davidgegiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Указал на недочёты в структуре ответа. Надо дополнительно проверить структуры остальных агрегаций, по тому же PR, который кидал

| | | * `image_url_resized` (object) |
| | | * `url_handle`(string) |
| | | * `group_id`(string) |
| | | * `_id` (string) |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь далеко не все поля внутри товара. Можно внимательнее посмотреть на структуру возвращаемого товара:
https://api-r46.halykmarket.kz/search?did=i6lyFZgSBK&shop_id=693ff081028570920fd8a6b971eb5e&sid=QJXwkaufPo&type=full_search&search_query=Пудра-бронзер&excluded_merchants=Perfume Home&locations=-1&excluded_brands=dior,estee lauder
А наиболее актуальную информацию по всем типам и форматам полей можно найти тут:
https://github.com/rees46/services/pull/32/files#diff-57a5ae4d5edcc6a24b9a99c89a3ac74c6aa962211fae79b15c5bd3ad1c190b94R1

| | | * `name` (string) |
| | | * `parent` (string) |
| | | * `url_handle` (string) |
| | | * `count` (integer) |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| image_url_resized | object | Object with resized images |
| url_handle | string | Relative product URL |
| group_id | string | ID of product group (aggregated variations) |
| _id | string | Internal ID |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

изменить исходя из комментариев выше

| url | string | Full URL to category |
| parent | string | ID of the parent category |
| url_handle | string | Relative URL path to the category |
| count | integer | Number of products in this category |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

изменить исходя из комментариев выше

@gochicus gochicus requested a review from davidgegiya May 29, 2025 08:31
Copy link

@davidgegiya davidgegiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Всё равно там не все возможные поля описаны. Я кидал ссылку на PR. Там есть все актуальные поля и их типы.
Пример для товара:
gift,
installment
....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants