Bug fix(accessControlProvider): resolve cacheTime issue for can function (#6749) #6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| // import { getXRay } from "@refinedev/devtools-internal"; |
There was a problem hiding this comment.
I think these commented lines were added by mistake.
There was a problem hiding this comment.
yes.... skipped my mind to take 'em off. will do that in a few minutes.....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…6749
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
The can function was being executed multiple times for each resource upon page reloads or when wrapped with CanAccess, even when the result could be cached.
cacheTime and staleTime configurations were not being respected, leading to performance degradation.
What is the new behavior?
Fixes Issue #6749: cacheTime and staleTime are now respected, ensuring that the results of the can function are cached for the specified time.
The can function will no longer run multiple times unnecessarily when resources are already evaluated, improving the page load time and performance.
Notes for reviewers
Please ensure that the cache handling logic is thoroughly tested, and the behavior is consistent across different resources.
If you have any concerns regarding the caching behavior, let me know, and we can refine it further.