Bug fix(accessControlProvider): resolve cacheTime issue for can function (#6749) #6753
Conversation
|
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| // import { getXRay } from "@refinedev/devtools-internal"; |
There was a problem hiding this comment.
I think these commented lines were added by mistake.
There was a problem hiding this comment.
yes.... skipped my mind to take 'em off. will do that in a few minutes.....
There was a problem hiding this comment.
@alicanerdurmaz, the commented lines has been removed.
| // Check if we have a cached value and if it's still valid | ||
| if (cacheEntry && Date.now() - cacheEntry.timestamp < cacheDuration) { | ||
| return { data: cacheEntry.result } as UseQueryResult<CanReturnType>; | ||
| } | ||
|
|
||
| const queryResponse = useQuery<CanReturnType>({ | ||
| ...mergedQueryOptions, |
There was a problem hiding this comment.
you must call hooks unconditionally https://react.dev/reference/rules/rules-of-hooks or it will
Thank you for helping to develop Refine, but we’d appreciate it if you could open the PR only after you’ve tested it. If you try running the access-control-casbin example you’ll see this error and the project won’t work:
Uncaught Error: Rendered fewer hooks than expected. This may be caused by an accidental early return statement.
at renderWithHooks (chunk-WBKLWWXU.js?v=52d2936b:11623:19)
at updateFunctionComponent (chunk-WBKLWWXU.js?v=52d2936b:14610:28)
at beginWork (chunk-WBKLWWXU.js?v=52d2936b:15952:22)
at beginWork$1 (chunk-WBKLWWXU.js?v=52d2936b:19789:22)
at performUnitOfWork (chunk-WBKLWWXU.js?v=52d2936b:19234:20)
at workLoopSync (chunk-WBKLWWXU.js?v=52d2936b:19173:13)
at renderRootSync (chunk-WBKLWWXU.js?v=52d2936b:19152:15)
at recoverFromConcurrentError (chunk-WBKLWWXU.js?v=52d2936b:18772:28)
at performSyncWorkOnRoot (chunk-WBKLWWXU.js?v=52d2936b:18915:28)
at flushSyncCallbacks (chunk-WBKLWWXU.js?v=52d2936b:9143:30)
| * @see {@link https://refine.dev/docs/api-reference/core/hooks/accessControl/useCan} for more details. | ||
| * Custom cache for `can` function results to optimize performance. | ||
| */ | ||
| const canCache = new Map<string, { result: CanReturnType; timestamp: number }>(); |
There was a problem hiding this comment.
I don’t think we need a custom cache here. TanStack Query already has an excellent caching mechanism.
…6749
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
The can function was being executed multiple times for each resource upon page reloads or when wrapped with CanAccess, even when the result could be cached.
cacheTime and staleTime configurations were not being respected, leading to performance degradation.
What is the new behavior?
Fixes Issue #6749: cacheTime and staleTime are now respected, ensuring that the results of the can function are cached for the specified time.
The can function will no longer run multiple times unnecessarily when resources are already evaluated, improving the page load time and performance.
Notes for reviewers
Please ensure that the cache handling logic is thoroughly tested, and the behavior is consistent across different resources.
If you have any concerns regarding the caching behavior, let me know, and we can refine it further.