fix(core): label and route fields of useMenu.menuItems shouldn't be deprecated
#6353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5fabf56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alicanerdurmaz
changed the title
label and route fields of useMenu.menuItems shouldn't be deprecated
refine
|
||||||||||||||||||||||||||||
| Project |
refine
|
| Branch Review |
fix/core/label-and-route-fields-of-menu-items-should-not-be-deprecated
|
| Run status |
|
| Run duration | 17m 22s |
| Commit |
|
| Committer | Alican Erdurmaz |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
37
|
Skipped
|
0
|
Passing
|
383
|
| View all changes introduced in this branch ↗︎ | |
BatuhanW
approved these changes
Sep 19, 2024
aliemir
approved these changes
Sep 23, 2024
aliemir
deleted the
fix/core/label-and-route-fields-of-menu-items-should-not-be-deprecated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
The
labelandroutefields inuseMenu().menuItemswere marked as deprecated, but they are not deprecated.What is the new behavior?
This change removes the deprecation warning for these fields because
useMenuautomatically handles the deprecation of these fields internally.fixes #6352