Skip to content

refactor(core): Use wildcard ESM import for papaparse - #6912

Closed
pcfreak30 wants to merge 1 commit into
refinedev:mainfrom
LumeWeb:issue/6909
Closed

refactor(core): Use wildcard ESM import for papaparse#6912
pcfreak30 wants to merge 1 commit into
refinedev:mainfrom
LumeWeb:issue/6909

Conversation

@pcfreak30

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes #6909

Notes for reviewers

@pcfreak30
pcfreak30 requested a review from a team as a code owner August 1, 2025 07:12
@changeset-bot

changeset-bot Bot commented Aug 1, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3a91571

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Aug 1, 2025

Copy link
Copy Markdown

Deploy Preview for refine-doc-live-previews ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3a91571
🔍 Latest deploy log https://app.netlify.com/projects/refine-doc-live-previews/deploys/688c70c0647fa40008ba11b3
😎 Deploy Preview https://deploy-preview-6912--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pcfreak30
pcfreak30 marked this pull request as draft August 1, 2025 17:53
@pcfreak30

pcfreak30 commented Aug 2, 2025

Copy link
Copy Markdown
Contributor Author

I made this a draft b/c i had to patch papaparse AMD wrapper itself. The root is both using CJS code and that vite isnt pre-processing this dep correctly after a lot of different thing tried.

refine has multiple dependencies like this. I now have refine loading in a dev server properly but it required a lot of patching...

I am unsure what the actual best approach to solve all of this would be since some upstreams are abandoned and some maintainers are resistant to ESM.

@stale

stale Bot commented Oct 1, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the wontfix This will not be worked on label Oct 1, 2025
@stale stale Bot closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] papaparse ESM importing

1 participant