-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(core/useList): select function passed to useQuery in useList causes inifite loops #7039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7506fbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
…eList_causes_inifite_loops
examples/use-list/src/App.css
Outdated
|
||
.menu { | ||
flex-shrink: 0; | ||
padding: 8px 16px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think relative sizing would be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comment. I would leave it as is because the UI in this example project is not important.
I created this example project using the refine
CLI command to test out if the useList
hook works properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I don't even use these stylings. So I removed them.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
What is the new behavior?
fixes #7022
fixes #6713
Notes for reviewers
Added an example project to test out the behaviour of useList when passing query params with memoized select function.
I'm not sure if I should leave this project in repo or should I delete it.
pnpm-lock file was automatically updated after running pnpm install