Skip to content

Conversation

vargash
Copy link

@vargash vargash commented Oct 6, 2025

Rendering a <div> as the parent for the DeleteButton prevent the button itself from showing and from showing the following buttons. Changing it to React's tag seems to solve the problem.

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

Currently, a simple <DeleteButton hideText recordItemId={row.id} /> inside a table is not rendering anything, even preventing following elements in the same cell to be rendered.

What is the new behavior?

The <DeleteButton> and any element after it is rendered correctly.

fixes (issue)

Notes for reviewers

Rendering a <div> as the parent for the DeleteButton prevent the button itself from showing and from showing the following buttons.
Changing it to React's tag seems to solve the problem.
@vargash vargash requested a review from a team as a code owner October 6, 2025 09:45
Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: 2150935

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 6, 2025

Deploy Preview for refine-doc-live-previews ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2150935
🔍 Latest deploy log https://app.netlify.com/projects/refine-doc-live-previews/deploys/68e38fabe727ec0008f89140
😎 Deploy Preview https://deploy-preview-7043--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vargash vargash changed the title Fix MUI DeleteButton <fix>(mui): DeleteButton not properly rendering Oct 6, 2025
@alicanerdurmaz
Copy link
Member

Hello @vargash, thanks for improving Refine.
We need changeset to release new version. Can you add please?

@BatuhanW
Copy link
Member

BatuhanW commented Oct 9, 2025

Please make sure to thoroughly read and follow our contribution guide. PRs that doesn't follow our contribution guide, will be closed.

https://refine.dev/docs/guides-concepts/contributing/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants