-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(core): deprecate useCustom result property for better type safety
#7110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(core): deprecate useCustom result property for better type safety
#7110
Conversation
Deprecate `result.data` in favor of `query.data?.data` to fix type safety issues where empty objects during loading could cause runtime errors. - Add @deprecated JSDoc and warnOnce warning - Update docs and examples with migration guide - Maintain backward compatibility Resolves #7088
🦋 Changeset detectedLatest commit: e7b22ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
refine
|
||||||||||||||||||||||||||||
| Project |
refine
|
| Branch Review |
fix/deprecate-use-custom-returned-result-value
|
| Run status |
|
| Run duration | 20m 05s |
| Commit |
|
| Committer | Alican Erdurmaz |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
22
|
|
|
0
|
|
|
378
|
| View all changes introduced in this branch ↗︎ | |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
The
useCustomhook returns aresult.dataproperty that always contains an empty object during loading states. This causes type safety issues where TypeScript cannot properly catch potential runtime errors when accessing nested properties.For example:
This is an undocumented breaking change that can lead to runtime errors.
What is the new behavior?
The
resultproperty is now deprecated with proper warnings and documentation:@deprecatedcomment to the type definition directing users to usequery.data?.dataRecommended usage:
This provides better type safety and aligns with TanStack Query patterns.
fixes #7088
Notes for reviewers
resultproperty is not removed, only deprecated - this maintains backward compatibility