-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(core): cached error state on login after forced logout #7124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- chore: add changeset
🦋 Changeset detectedLatest commit: 8ddfeda The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
hey @arndom, this test is failing: Could you take a look? |
|
@alicanerdurmaz I locally ran the test suite for the auth-keycloak example, and they all passed. auth-keycloak
login
√ should login (17329ms)
√ should redirect to /login if user not authenticated (7790ms)
logout
√ should logout (10043ms)
get identity
√ should render getIdentity response on header (5869ms)
4 passing (42s)
(Results)
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 4 │
│ Passing: 4 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
│ Screenshots: 0 │
│ Video: false │
│ Duration: 41 seconds │
│ Spec Ran: all.cy.ts │
└────────────────────────────────────────────────────────────────────────────────────────────────┘I noticed the same example fails in the github runner for other unrelated-to-auth PRs:
So it may be an issue within the github runner...could you take a look? |
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
Despite a successful login after being forced to log out, there is an error loop.
What is the new behavior?
On logout, all queries are invalidated, ensuring new data is fetched on login
resolves #6997
Notes for reviewers