fix(antd): replace Card variant prop with bordered for compatibility (fixes #7138) #7162
Conversation
Replace deprecated `variant="borderless"` with `bordered={false}` in Create component
to maintain compatibility with Ant Design 5.21+ where variant prop is deprecated.
Fixes refinedev#7138
Replace deprecated `variant="borderless"` with `bordered={false}` in Edit component
to maintain compatibility with Ant Design 5.21+ where variant prop is deprecated.
Fixes refinedev#7138
Replace deprecated `variant="borderless"` with `bordered={false}` in Show component
to maintain compatibility with Ant Design 5.21+ where variant prop is deprecated.
Fixes refinedev#7138
🦋 Changeset detectedLatest commit: 83b403a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alicanerdurmaz
left a comment
alicanerdurmaz
left a comment
There was a problem hiding this comment.
Hi @harikapadia999, thanks for your effort, but this PR is quite incorrect. We shouldn’t use bordered={false}; we need to use variant="borderless" instead. The bordered prop is not even mentioned in the docs: https://5x.ant.design/components/card
All we needed to do was bump the version in https://github.com/refinedev/refine/blob/main/packages/antd/package.json#L51 so that 5.23 can never be used (it’s probably not installed anywhere right now, but we should do it just in case).
3 participants
Description
Fixes #7138
Replaced deprecated
variant="borderless"withbordered={false}in Ant Design CRUD components to maintain compatibility with Ant Design 5.21+ where the variant prop is deprecated.Changes
Components Updated
variant="borderless"withbordered={false}variant="borderless"withbordered={false}variant="borderless"withbordered={false}Impact
✅ Removes deprecation warnings - No more console warnings in Ant Design 5.21+
✅ Maintains visual consistency - Cards still appear borderless
✅ Backward compatible - Works with older Ant Design versions
✅ Future-proof - Aligns with Ant Design's API direction
Visual Comparison
The visual appearance remains identical - cards continue to render without borders. This is purely an API compatibility fix.
Before:
After: