Skip to content

Conversation

@yasuo72
Copy link

@yasuo72 yasuo72 commented Jan 8, 2026

Fixes #7185

This PR updates the ShadCN auto-save indicator component and its registry JSON so that
the translation keys match the i18n guide:

  • autoSave.loading
  • autoSave.success
  • autoSave.error
  • autoSave.idle

This ensures that when users follow the documented autoSave translations, the
indicator shows the correct translated text instead of raw keys.

Tests:

  • pnpm run test -- --scope @refinedev/refine-ui (no tests defined for this package)
  • pnpm run test -- --scope @refinedev/antd (previously run while working in this repo)

@yasuo72 yasuo72 requested a review from a team as a code owner January 8, 2026 21:15
@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2026

⚠️ No Changeset found

Latest commit: 954bd25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@erenkurnaz
Copy link
Contributor

Hello @yasuo72, thanks for taking the time to open this PR and contribute.

Before we merge, one small request: we don’t think the mock changes are necessary for this update. If you could revert the mock-related changes We can merge right after that’s done.

@yasuo72 yasuo72 force-pushed the fix/refine-ui-auto-save-keys branch from 54837e0 to ca2bbb7 Compare January 14, 2026 14:22
@yasuo72 yasuo72 force-pushed the fix/refine-ui-auto-save-keys branch from ca2bbb7 to 59efa96 Compare January 14, 2026 19:37
@yasuo72
Copy link
Author

yasuo72 commented Jan 14, 2026

done mock changes problem reverted

@BatuhanW BatuhanW enabled auto-merge (squash) January 15, 2026 08:07
@yasuo72 yasuo72 marked this pull request as draft January 15, 2026 16:28
auto-merge was automatically disabled January 15, 2026 16:28

Pull request was converted to draft

@yasuo72 yasuo72 marked this pull request as ready for review January 15, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ShadCN auto-save-indicator Translation Key should change & auto-save-indicator not added

2 participants